Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

availableStorage takes a lot of time #798

Closed
AgapovOne opened this issue Jul 3, 2023 · 1 comment
Closed

availableStorage takes a lot of time #798

AgapovOne opened this issue Jul 3, 2023 · 1 comment

Comments

@AgapovOne
Copy link

Hello. We are using Snowplow in our project to track a lot of things. And tracking in main thread on scroll is hard because of availableStorage ion DeviceInfoMonitor. It takes a lot of time using main thread with multiple synchronous calls to snowplow. UI freezes for significant time (50ms for one event)

Could you consider some cache layer for availableStorage field, or other ways to optimize this?

@matus-tomlein
Copy link
Contributor

Hi @AgapovOne,

Thank you for the feedback!

There already is a cache layer that prevents updating the availableStorage on every event, but the minimum update frequency is set to 100ms (see here). We can certainly increase this setting!

Also as a temporary workaround, you can disable tracking this property using the TrackerConfiguration.platformContextProperties setting (see API docs here).

dskuza pushed a commit to Pocket/pocket-ios that referenced this issue Aug 8, 2023
Be more aggressive about what we want Snowplow to automatically add as properties to mobile contexts. For example, we do not require knowing device storage, yet there was potential for it causing hangs within the Snowplow SDK: snowplow/snowplow-ios-tracker#798. This list is based on what could be "skipped" when brought up to EM.
dskuza pushed a commit to Pocket/pocket-ios that referenced this issue Aug 8, 2023
Be more aggressive about what we want Snowplow to automatically add as properties to mobile contexts. For example, we do not require knowing device storage, yet there was potential for it causing hangs within the Snowplow SDK: snowplow/snowplow-ios-tracker#798. This list is based on what could be "skipped" when brought up to EM.
CMasterson pushed a commit to Pocket/pocket-ios that referenced this issue Aug 8, 2023
Be more aggressive about what we want Snowplow to automatically add as properties to mobile contexts. For example, we do not require knowing device storage, yet there was potential for it causing hangs within the Snowplow SDK: snowplow/snowplow-ios-tracker#798. This list is based on what could be "skipped" when brought up to EM.
Gio2018 pushed a commit to Pocket/pocket-ios that referenced this issue Aug 8, 2023
* fix(extension) Continue looping through items when saving from extension

* fix(extension) Refactor code

* fix(extension) Fix warning

* fix(extension) Add happy-path test

* project(spm): update snowplow

* refactor(analytics): request specific platform context properties

Be more aggressive about what we want Snowplow to automatically add as properties to mobile contexts. For example, we do not require knowing device storage, yet there was potential for it causing hangs within the Snowplow SDK: snowplow/snowplow-ios-tracker#798. This list is based on what could be "skipped" when brought up to EM.

* fix(extension) Fix linting issue

* fix(extension) Change to only save the first item encountered

---------

Co-authored-by: David Skuza <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants