Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for connection during dry-run before steps are run #137

Open
mhadam opened this issue Oct 15, 2018 · 3 comments
Open

Test for connection during dry-run before steps are run #137

mhadam opened this issue Oct 15, 2018 · 3 comments
Assignees
@rzats
Milestone
Version 0.8.0

Comments

@mhadam
Copy link
Contributor

mhadam commented Oct 15, 2018 •
edited
Loading

It seems that the connection is tested on each query, and that's excessive.

Add the connection test for each target in run.go:
https:/snowplow/sql-runner/blob/develop/sql_runner/run.go#L255
@alexanderdean alexanderdean added this to the Version 0.8.0 milestone Oct 15, 2018
@alexanderdean
Copy link
Member

Is this a bug in the v0.7.0 series @mhadam ?

@mhadam
Copy link
Contributor Author

mhadam commented Oct 15, 2018 •
edited
Loading

Yes. Not a show-stopper, it does what it needs to, it just gets called more than it needs to be.

@alexanderdean
Copy link
Member

Cool, scheduled into the next minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rzats rzats

Labels
None yet
Projects
None yet
Milestone
Version 0.8.0
Development

No branches or pull requests
3 participants
@alexanderdean @mhadam @rzats