Use strict-equals (Fixes #265) (#266)

* Use strict-equals (Fixes #265)

* Use list since tags is always a list

* tags assignment not needed since its already set in constructor

* Ensure 'tags' is always a list

* Remove redundant code

src/commit.ts

@@ -57,8 +57,7 @@ export class Commit {
  this.parent ? [...this.parent] : []);
  commit.hash = this.hash;
 
- commit.tags = [];
- if (this.tags != null) {
+ if (this.tags.length > 0) {
  commit.tags = [...this.tags];
  }
 
@@ -85,10 +84,6 @@ export class Commit {
  return;
  }
 
- if (this.tags == null) {
- this.tags = [];
- }
-
  if (this.tags.includes(tag)) {
  return;
  }

src/odb.ts

@@ -135,6 +135,14 @@ export class Odb {
  return commits.map((commit: any) => {
  const tmpCommit = commit;
 
+ if (!tmpCommit.tags) {
+ tmpCommit.tags = [];
+ }
+
+ if (!tmpCommit.userData) {
+ tmpCommit.userData = {};
+ }
+
  tmpCommit.date = new Date(tmpCommit.date); // convert number from JSON into date object
  const c: Commit = Object.setPrototypeOf(tmpCommit, Commit.prototype);
  c.repo = this.repo;

src/reference.ts

@@ -63,7 +63,7 @@ export class Reference {
  });
 
  ref.userData = {};
- if (this.userData != null) {
+ if (this.userData !== null) {
  ref.userData = { ...this.userData };
  }