Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: if matched display the project ID #1271

Merged
merged 1 commit into from
Jul 15, 2020
Merged

feat: if matched display the project ID #1271

merged 1 commit into from
Jul 15, 2020

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jul 14, 2020 •
edited
Loading

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Include projectId in the JSON output.
Screen Shot 2020-07-14 at 15 59 55

@lili2311 lili2311 self-assigned this Jul 14, 2020
@lili2311 lili2311 force-pushed the feat/display-project-id-if-matched branch from 24ef807 to e181806 Compare July 14, 2020 16:43
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2020 •
edited by lili2311
Loading

Expected release notes (by @lili2311)

features:
if present display projectId in --json output (e181806)

others (will not be included in Semantic-Release notes):
run yarn v2 tests for Node 10 (f82c81f)
add checkout step to release job (496f4d4)
add test to check if new version of snyk is not broken (c2ddf1d)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@lili2311 lili2311 marked this pull request as ready for review July 15, 2020 08:26
@lili2311 lili2311 requested review from a team as code owners July 15, 2020 08:26
@ghost ghost requested review from anthogez and ekbsnyk July 15, 2020 08:26
@JackuB JackuB changed the title feat: if matched displaythe project ID feat: if matched display the project ID Jul 15, 2020
@lili2311 lili2311 merged commit 3d76c61 into master Jul 15, 2020
@lili2311 lili2311 deleted the feat/display-project-id-if-matched branch July 15, 2020 09:10
@snyksec
Copy link

snyksec commented Jul 15, 2020

🎉 This PR is included in version 1.362.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@snyk-bot snyk-bot mentioned this pull request Aug 7, 2020
Open
This was referenced Aug 16, 2020
Open
Open
Open
Open
This was referenced Aug 27, 2020
Open
Open
Open
Open
@EitanGayor EitanGayor mentioned this pull request Feb 22, 2021
Open
@romathur romathur mentioned this pull request Feb 22, 2021
Open
@EitanGayor EitanGayor mentioned this pull request Feb 23, 2021
Open
@joshje joshje mentioned this pull request Feb 23, 2021
Open
@RyanPHigh RyanPHigh mentioned this pull request Feb 23, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jul 27, 2022
Closed
@swinton swinton mentioned this pull request Aug 2, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 30, 2022
Open
@shaniHerz shaniHerz mentioned this pull request Oct 3, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Feb 19, 2023
Merged
@AliADDOU AliADDOU mentioned this pull request Apr 15, 2024
Open
@romathur romathur mentioned this pull request Apr 16, 2024
Open
@RyanPHigh RyanPHigh mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackuB JackuB JackuB approved these changes

@anthogez anthogez Awaiting requested review from anthogez

@ekbsnyk ekbsnyk Awaiting requested review from ekbsnyk

Assignees

@lili2311 lili2311

Labels
released ☠️ tech services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lili2311 @snyksec @JackuB