feat: support pipfile on containerized cli #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
jasiskis
changed the title
jasiskis
force-pushed
the
feat/support-pipfile-on-containerized-cli
branch
from
c88bf24
to
04a0c35
Compare
odinn1984
reviewed
Jul 27, 2020
| pip install -U -e "${PROJECT_PATH}" | ||
| elif [ -f "${PROJECT_PATH}/Pipfile" ]; then | ||
| echo "Found Pipfile" | ||
| installPipfileDeps |
There was a problem hiding this comment.
What do you mean? This was always executed, to install the python deps if those files are found
There was a problem hiding this comment.
just making sure it's not something custom that i missed it's definition i didn't use pipfile beforehand :)
python on containerized env will auto detects only if file is not provided
jasiskis
force-pushed
the
feat/support-pipfile-on-containerized-cli
branch
from
04a0c35
to
57e860b
Compare
odinn1984
approved these changes
Jul 27, 2020
aviadhahami
approved these changes
Jul 27, 2020
|
🎉 This PR is included in version 1.367.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Aug 16, 2020
This was referenced Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It allows the user to specify a -f
Pipfilewhen running the CLI in a containerized environment.Also, fix issues with automatically detecting a
setup.pyfile and installing its dependencies, but only if no-fwas provided.