fix: fix combination of rubygems and --all-projects #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
admons
force-pushed
the
fix/rubygems-with-all-projects
branch
5 times, most recently
from
ed4dffd
to
5706ef8
Compare
today all rebygems projects have the same project name with --all-projects flag. this adds the nested dir name into the project name.
admons
force-pushed
the
fix/rubygems-with-all-projects
branch
from
5706ef8
to
5fef84f
Compare
admons
requested review from
hadasgo,
JamesPatrickGill,
gitphill,
mika-bar,
ekbsnyk and
cristian-pana
admons
commented
Nov 3, 2021
|
|
||
| export async function inspect( | ||
| root: string, | ||
| targetFile: string, | ||
| options: types.Options = {}, |
There was a problem hiding this comment.
We already send the options when we run inspect, but never used it here.
All changes in this file is just to propagate options to the plugin
muscar
approved these changes
Nov 3, 2021
admons
commented
Nov 3, 2021
| return { | ||
| packageName: path.basename(root), | ||
| packageName: options.allSubProjects |
There was a problem hiding this comment.
Because the name of the package here is the actual name of the project, and the project name is a part of the identifier, we only want to change this in the problematic area we're facing of 2 or more projects with the '--all-projects` flag.
This was referenced Jan 16, 2022
This was referenced Feb 1, 2022
This was referenced Sep 22, 2022
This was referenced Sep 24, 2022
This was referenced Sep 26, 2022
This was referenced Oct 1, 2022
This was referenced Oct 3, 2022
This was referenced Feb 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
today all rebygems projects have the same project name with --all-projects flag.
this adds the nested dir name into the project name.