fix: skip files greater than or equal to 2GB #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthogez
force-pushed
the
update-cpp-plugin-to-v2.12.4
branch
from
2dd3ccc
to
594d4e8
Compare
Due to limitations with nodes Buffer, we agreed to skip files greater than or equal to 2GB. This is implemented by following changes: - Add file size validation to find.ts
dekelund
force-pushed
the
update-cpp-plugin-to-v2.12.4
branch
from
594d4e8
to
f72458b
Compare
ghost
approved these changes
Nov 3, 2021
This was referenced Jan 16, 2022
This was referenced Feb 1, 2022
This was referenced Sep 22, 2022
This was referenced Sep 26, 2022
This was referenced Oct 1, 2022
This was referenced Oct 3, 2022
This was referenced Feb 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: skip files greater than or equal to 2GB
Due to limitations with nodes Buffer, we agreed
to skip files greater than or equal to 2GB.
This is implemented by following changes:
To test this fix, run the CLI test with an unmanaged
project containing a file of at least 2GB. Consider
it a success if it's not crashing, and we generate
signatures for all other files.