Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add driver version to IaC sarif outout #2578

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

YairZ101
Copy link
Contributor

@YairZ101 YairZ101 commented Jan 16, 2022

What does this PR do?

This PR adds the current version of the CLI to the SARIF output under the driver field.
This is a direct continuation of the following PR: #2524

How should this be manually tested?

  1. Run a test with the --sarif flag
  2. under runs[].tool.driver.version you'll found the newly added driver version

What are the relevant tickets?

https://snyksec.atlassian.net/jira/software/c/projects/CFG/boards/301?modal=detail&selectedIssue=CFG-1313

Additional questions

What's the meaning of life? :)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2022

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/lib/formatters/iac-output.ts
⚠️ You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against 247d33e

@YairZ101 YairZ101 force-pushed the feat/add_driver_version_to_sarif_output branch from c98064f to 247d33e Compare January 16, 2022 16:40
@YairZ101 YairZ101 marked this pull request as ready for review January 16, 2022 16:50
@YairZ101 YairZ101 requested a review from a team as a code owner January 16, 2022 16:50
@YairZ101 YairZ101 merged commit 0e8037e into master Jan 18, 2022
@YairZ101 YairZ101 deleted the feat/add_driver_version_to_sarif_output branch January 18, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants