chore: Fix IaC test exit code when issues are found #3501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
1
instead of0
, as is expected by the Snyk CLI (source).Where should the reviewer start?
How should this be manually tested?
snyk iac test
with a directory/file with issues, in all three formats: text, JSON, SARIF.snyk iac test --experimental
with a directory/file with issues, in all three formats: text, JSON, SARIF.snyk iac test
with a directory/file without issues, in all three formats: text, JSON, SARIF.snyk iac test --experimental
with a directory/file without issues, in all three formats: text, JSON, SARIF.Any background context you want to provide?
0
, but based on the status codes list in the CLI’s help doc:We should receive
1
when issues were found.Running
snyk iac test
in all output formats confirms it, as it currently returns exist code1
.Additional information