Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CocoaPods support #780

Merged
merged 1 commit into from
Sep 30, 2019
Merged

feat: add CocoaPods support #780

merged 1 commit into from
Sep 30, 2019

Conversation

mrackwitz
Copy link
Contributor

@mrackwitz mrackwitz commented Sep 30, 2019

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

This PR integrates the CocoaPods plugin to the Snyk CLI:

  • adding CocoaPods and its artifacts as supported dependency managers in respective enums
  • testing the integration via the acceptance tests
  • adding a help text to document the --strict-out-of-sync option (postponed to regular release, with auto-detect / without explicit opt-in)

How should this be manually tested?

The CocoaPods plugin repo includes some tests, which have fixtures with Podfile and Podfile.lock. These can be used for snyk test or snyk monitor

help/file.txt Outdated Show resolved Hide resolved
help/help.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@lili2311 lili2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@darscan darscan merged commit 7802663 into master Sep 30, 2019
@darscan darscan deleted the feat/cocoapods branch September 30, 2019 18:46
@snyksec
Copy link

snyksec commented Sep 30, 2019

🎉 This PR is included in version 1.230.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants