[WIP] fix: check token for validity before making any requests #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
gitphill
reviewed
Nov 26, 2019
src/lib/api-token.ts
Outdated
| import * as config from './config'; | ||
| import * as userConfig from './user-config'; | ||
|
|
||
| export function api() { | ||
| // note: config.TOKEN will potentially come via the environment | ||
| return config.api || config.TOKEN || userConfig.get('api'); | ||
| } | ||
| async function isTokenValid(token: string) { |
There was a problem hiding this comment.
we have very similar function in src/cli/commands/auth/is-authed.ts - could reuse (use this function there) to avoid duplication?
There was a problem hiding this comment.
Was looking for this one but haven't found :( Nice catch 👍
src/lib/api-token.ts
Outdated
|
|
||
| export function apiTokenExists() { | ||
| return (response as any).body; |
There was a problem hiding this comment.
type the function return object?
dkontorovskyy
force-pushed
the
fix/wrong-auth-error
branch
from
a8ebf5c
to
5c5d6c6
Compare
|
Closing this PR, cos this is not right approach |
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix auth error if
experimental-dep-graphexists.If cli was invoked with
experimental-dep-graphflag and invalid token, user will get error messageFeature flag 'experimental-dep-graph' is not currently enabled for your org, to enable please contact snyk support, cos token wasn't checked for validity and line https:/snyk/snyk/blob/master/src/cli/commands/monitor/index.ts#L91 will return actually401 Not Authorised, but because we doisFFSupported.okand it wasundefined, user will see totally unrelated error message.