-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing quote in README.md sample #97
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The closing `"` was missing from the `data-canonical-src` attribute in the HTML badge sample code.
@koczkatamas thanks for this small but important fix! |
adrukh
pushed a commit
that referenced
this pull request
Jul 27, 2017
Suggested by @koczkatamas as #97
Closing as this has been fixed! |
This was referenced Jul 27, 2021
This was referenced Sep 12, 2021
This was referenced Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The closing
"
was missing from thedata-canonical-src
attribute in the HTML badge sample code.What does this PR do?
Fix a typo.
Where should the reviewer start?
Github changes window.
How should this be manually tested?
It's just a typo.
Any background context you want to provide?
No.
What are the relevant tickets?
None.
Screenshots
Nope.
Additional questions
I hereby give permission to use my such great contribution to the project without signing a CLA. Seriously, I hope you'll make an exception in the CLA for small changes like this one...