fix: changing global proxy setting as a side effect #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterSchafer
changed the title
PeterSchafer
force-pushed
the
fix/HEAD-674_restore_system_proxy
branch
from
edd323a
to
d00c855
Compare
PeterSchafer
force-pushed
the
fix/HEAD-674_restore_system_proxy
branch
from
d00c855
to
0071b1e
Compare
|
🎉 This PR is included in version 2.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix changing a value that was passed by value.
Where should the reviewer start?
How should this be manually tested?
added unit tests instead of manually testing.
Any background context you want to provide?
What are the relevant tickets?
HEAD-820
Screenshots
Additional questions