Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solve setup tools not installed on 3.12 python versions #242

Closed
wants to merge 3 commits into from

Conversation

MishaEnso
Copy link

@MishaEnso MishaEnso commented Jul 18, 2024

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

####What this PR do?
Fix to T3S-84 issue , based on support ticket 81735 , basically setup tools were not installed since that updateSetuptools procedure was getting the wrong values.
Setup tools were deprecated since Python 3.12 version , for this scenario special procedure was created , however it has an issue which this PR solving.

####What files were affected?
Index.ts
inspect-implementations.ts
test/system/inspect.spec.ts - fixed values to enable circle-ci

####Relevant Support Tickets?
Jira T3S-84 - Zendesk 81735
Jira T3S-98 - Zendesk 85170

@MishaEnso MishaEnso requested a review from gemaxim July 18, 2024 09:40
@MishaEnso MishaEnso requested a review from a team as a code owner July 18, 2024 09:40
@CLAassistant
Copy link

CLAassistant commented Jul 18, 2024

CLA assistant check
All committers have signed the CLA.

@gemaxim
Copy link
Contributor

gemaxim commented Jul 30, 2024

Changes were merged in this PR: #244 + tests

@gemaxim gemaxim closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants