Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement data access module, replace file resource #1199

Merged
merged 2 commits into from
May 8, 2022

Conversation

nezhar
Copy link
Collaborator

@nezhar nezhar commented May 7, 2022

This is the first step into movidng from ngx-resource-factory to our rest api client generate from the OpenAPI document

This PR installs and configures the module, prepares the environment for paralel usage of services and resources and replaces FileResource with FileService.

@nezhar nezhar requested a review from sterapps May 7, 2022 19:53
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #1199 (78331e4) into master (39a8ca1) will increase coverage by 0.28%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master    #1199      +/-   ##
==========================================
+ Coverage   42.83%   43.12%   +0.28%     
==========================================
  Files          56       55       -1     
  Lines         705      698       -7     
  Branches       43       43              
==========================================
- Hits          302      301       -1     
+ Misses        399      393       -6     
  Partials        4        4              
Impacted Files Coverage Δ
src/app/services/services.module.ts 50.00% <ø> (ø)
src/environments/environment.ts 100.00% <ø> (ø)
src/app/components/snippet/snippet.component.ts 50.00% <57.14%> (-3.58%) ⬇️
.../components/set-password/set-password.component.ts 48.27% <0.00%> (+10.34%) ⬆️
src/app/layout/sidebar/sidebar.component.ts 100.00% <0.00%> (+20.00%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@nezhar nezhar force-pushed the data-access-module branch 2 times, most recently from 491af60 to 5f54593 Compare May 7, 2022 21:08
@nezhar nezhar merged commit afa5877 into master May 8, 2022
@nezhar nezhar deleted the data-access-module branch May 10, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants