Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'git secret changes' does not work unless passed secret filenames #153

Closed
joshrabinowitz opened this issue Apr 17, 2018 · 2 comments
Closed
Labels
Milestone

Comments

@joshrabinowitz
Copy link
Collaborator

Contrary to the docs, git secret changes does not work unless you pass it filenames of *.secret files.

In all cases with a git-secret repo, if you type

`git secret changes`

You get no errors, but output like:

     % git secret changes
    changes in /full/path/config.ini:
    <blank line>

For the command to work it must be passed the secret filenames (config.ini.secret).

@sobolevn
Copy link
Owner

That's a bug. It should not be this way.

git secret changes should by default output all changes.
And when some filenames are given - only limit this changes by these filenames.

@sobolevn sobolevn added the bug label Apr 17, 2018
@sobolevn sobolevn added this to the 0.2.4 milestone Apr 17, 2018
@joshrabinowitz
Copy link
Collaborator Author

joshrabinowitz commented Apr 17, 2018

If you pass an un-hidden file you at least get a non-zero exit code:

 % git secret changes no_such_file
gpg: can't open `/home/joshr/gitsrc/jcreds-amazon/no_such_file.secret': No such file or directory
gpg: decrypt_message failed: No such file or directory
% echo $?
2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants