Silent error on secret hide when GPG key expires

[rjcoelho]

When a GPG key expires we get no output when doing a "git secret hide". We should get a GPG key expired error message (if possible).

[sobolevn]

Yeap, that's true. This check should also happen when we try to add (git secret tell) an expired key.

[rjcoelho]

Basically any call to gpg should check for error codes and report then to stderr (and stop the command). Again if this is possible.

[joshrabinowitz]

Could someone write a test in a PR to show the problem?

[joshrabinowitz]

@rjcoelho I think this is what you're asking for: PR #205 'more careful error checking running gpg'

[joshrabinowitz]

I think we can close this, @rjcoelho please let us know if PR #205 fixes the issues you raise here.

[rjcoelho]

@joshrabinowitz it solve my issue. Thanks for such a speedy solution.

[joshrabinowitz]

re-opened until #205 is in the released code merged.

[joshrabinowitz]

this is a dup o #238