Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible typo in src/commands/git_secret_reveal.sh #325

Closed
krufab opened this issue Jan 27, 2019 · 2 comments
Closed

Possible typo in src/commands/git_secret_reveal.sh #325

krufab opened this issue Jan 27, 2019 · 2 comments
Assignees
Labels

Comments

@krufab
Copy link
Contributor

krufab commented Jan 27, 2019

Possible typo in src/commands/git_secret_reveal.sh
At line 72 of current master branch (65fe4c4), there is an unused redirection.

@joshrabinowitz
Copy link
Collaborator

yes, you are correct. Good catch @krufab !

@joshrabinowitz
Copy link
Collaborator

Thanks again for this issue report and the related patch, @krufab !

joshrabinowitz added a commit that referenced this issue Jan 27, 2019
krufab pushed a commit to krufab/git-secret that referenced this issue Feb 5, 2019
Removed unneded redirection of path_mappings (sobolevn#326)

[safe-hide-and-reveal] Added param -s to hide and safe commands

record change from pr sobolevn#325 (sobolevn#327)

remove diagnostic output from tests (sobolevn#329)

Fix link to contributors on github. (sobolevn#332)

[safe-hide-and-reveal] Updated code an added tests

[safe-hide-and-reveal] Added diffutils to alpine test_dependencie packages

[safe-hide-and-reveal] Added check to prevent using BusyBox diff as it does not support -D
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants