-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: "git secret hide" should only touch modified files #92
Comments
Thanks! That's a good idea indeed. Do you have any free time to make a PR for this? |
@sobolevn Yes, I might have time. I'll need to get acquainted with the code first, though. I'll try to give it a whirl this week. |
(sorry for the long message -- just want to get this right) There are a couple of tricky parts to this: Problem 1 Problem 2
So, the approach will be:
If we run into trouble decrypting the ciphertext or listing keys, we fall back to the current behavior, to replace all ciphertext. @sobolevn Please let me know if you're ok with my plans for solving these problems. |
I think that this is a nice way to solve it. Just one thing to mention. This change is quite big. And it can break stuff people are already using. I'm thinking about releasing it with |
Looks like |
can you please check it and probably reopen this issue? It should be solved in #107 by @hurricanehrndz |
Hello @skywinder, If you use the
If there's a discrepancy between the docs of git-secret and what it does, or if you'd like it to behave differently than it does, please open a new ticket for the issue. |
Gotcha, thanks. In this case, I just want to add this to the manual to the section, there you talking about pre-commit hook. So mine looks like this now:
I can add this example to https://git-secret.io/ , but can't find is there open source? gh-pages looks different. Otherwise I can add this section to readme if you want to. |
This should definitely be added as pre-commit hook example to the docs! |
@Mobe91 if you submit a PR we will consider! |
@joshrabinowitz is it sufficient to add the changes to |
@Mobe91 , sure, you can add them to man/man7/git-secret.7.ronn the man page is auto-generated from that file |
It would be nice if
git secret hide
would only re-encrypt files if the underlying plaintext file has changed.What are the steps to reproduce this issue?
git secret hide
git commit -am "save secrets"
git secret hide
git status
What happens?
git status
shows that git-secret-hide has rewritten all of my secret files, plus the random_seed file.What were you expecting to happen?
Ideally, the
git secret hide
in step 3 would have been a no-op since none of the underlying plaintext has changed.What versions of software are you using?
Operating system: Mac OS X 10.11.6 (El Capitan)
git-secret
version: 0.2.2Shell type and version: zsh 5.0.8 (x86_64-apple-darwin15.0)
The text was updated successfully, but these errors were encountered: