Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SECRETS_TEST_VERBOSE can be 0 #816

Merged
merged 2 commits into from
Apr 2, 2022
Merged

SECRETS_TEST_VERBOSE can be 0 #816

merged 2 commits into from
Apr 2, 2022

Conversation

sobolevn
Copy link
Owner

@sobolevn sobolevn commented Apr 2, 2022

Closes #815

@sobolevn
Copy link
Owner Author

sobolevn commented Apr 2, 2022

Related: I have no idea how to change test / osx-ci (0) to something more meaningful 🤔

Probably we can use SECRETS_TEST_VERBOSE=x as a matrix spec.

@sobolevn
Copy link
Owner Author

sobolevn commented Apr 2, 2022

Done!

joshrabinowitz
joshrabinowitz approved these changes Apr 2, 2022
View reviewed changes
Copy link
Collaborator

@joshrabinowitz joshrabinowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I'd love to also remove the _SECRETS_VERBOSE env var and just use SECRETS_VERBOSE everywhere, but that's outside the scope of this PR

@sobolevn sobolevn merged commit a97dd7f into master Apr 2, 2022
@sobolevn sobolevn deleted the sobolevn-patch-4 branch June 5, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshrabinowitz joshrabinowitz joshrabinowitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ensure github action non-verbose osx test doesn't show verbose output
2 participants
@sobolevn @joshrabinowitz