Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set state #20

Merged
merged 4 commits into from
Nov 7, 2017
Merged

Ability to set state #20

merged 4 commits into from
Nov 7, 2017

Conversation

Virviil
Copy link
Collaborator

@Virviil Virviil commented Nov 2, 2017

VK has ability to pass you back any string, that is set inda "state" parameter.

This can be used to save "session_id" to prevent middle attacks on the auth process.

So, redirect into /auth/vk?state=<session_id> should work.
After that, this state should be saved inside success struct

@Virviil
Copy link
Collaborator Author

Virviil commented Nov 2, 2017

I'm definitely need soome help with this changing, because don't understand the internal structure of success response because of lack of documentation

@coveralls
Copy link

coveralls commented Nov 2, 2017

Coverage Status

Coverage remained the same at 85.915% when pulling 209ab1a on Virviil:adding-scope into 95a169d on sobolevn:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.915% when pulling 209ab1a on Virviil:adding-scope into 95a169d on sobolevn:master.

@sobolevn
Copy link
Member

sobolevn commented Nov 3, 2017

Sure! Maybe we should start with the falling test?
I guess API and documentation could be changed, I have not updated this package in a while.

@coveralls
Copy link

coveralls commented Nov 7, 2017

Coverage Status

Coverage remained the same at 85.915% when pulling ee20f5d on Virviil:adding-scope into 95a169d on sobolevn:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.915% when pulling ee20f5d on Virviil:adding-scope into 95a169d on sobolevn:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.915% when pulling ee20f5d on Virviil:adding-scope into 95a169d on sobolevn:master.

@coveralls
Copy link

coveralls commented Nov 7, 2017

Coverage Status

Coverage decreased (-45.6%) to 40.278% when pulling 12eae4d on Virviil:adding-scope into 95a169d on sobolevn:master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 7, 2017

Coverage Status

Coverage decreased (-45.6%) to 40.278% when pulling 12eae4d on Virviil:adding-scope into 95a169d on sobolevn:master.

@Virviil Virviil changed the title WIP: Ability to set state Ability to set state Nov 7, 2017
@coveralls
Copy link

coveralls commented Nov 7, 2017

Coverage Status

Coverage increased (+0.2%) to 86.111% when pulling eb3130f on Virviil:adding-scope into 95a169d on sobolevn:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 86.111% when pulling eb3130f on Virviil:adding-scope into 95a169d on sobolevn:master.

@Virviil
Copy link
Collaborator Author

Virviil commented Nov 7, 2017

Test were fixed.
I've also tested how it's working in project.

@sobolevn, plz connect me via telegram: https://t.me/virviil

@sobolevn
Copy link
Member

sobolevn commented Nov 7, 2017

@Virviil thanks for your work!

Sorry, but I don't have a telegram account.
We can chat in #elixirlang slack. My nickname is the same.
You can also write me an email, if that more convenient to you.

@sobolevn sobolevn merged commit 0a5f645 into ueberauth:master Nov 7, 2017
@sobolevn
Copy link
Member

sobolevn commented Nov 7, 2017

Released! https://hex.pm/packages/ueberauth_vk

te0retik pushed a commit to KosyanMedia/ueberauth_vk that referenced this pull request Sep 22, 2021
Adds ability to set an extra param to vk.
It improves security.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants