Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map file absent from dist folder and from minified file #237

Closed
jlowcs opened this issue Apr 29, 2015 · 5 comments
Closed

map file absent from dist folder and from minified file #237

jlowcs opened this issue Apr 29, 2015 · 5 comments

Comments

@jlowcs
Copy link

jlowcs commented Apr 29, 2015

The sockjs-1.0.0-beta.12.js currently references a sockjs.js.map that is absent from the dist folder.

Also, shouldn't that sourceMappingURL be in the minified file instead of the non-minified file?

@brycekahle
Copy link
Contributor

I can get the source maps added to the repo. Both versions have source maps because they are combined from individual modules. The source map allows you to debug as if they were still separated out.

@deependraus
Copy link

Has the map been added? I still do not see it in the dist.

@brycekahle
Copy link
Contributor

Not yet. I will close the issue when I have added it.

@ngocdaothanh
Copy link
Contributor

Hi, can you add the map file? It's quite annoying when seeing
sockjs.js.map 404 Not Found
in web server access log all the time.

@brycekahle
Copy link
Contributor

I've updated the build script to add the file to the dist folder. The next release will add the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants