FIX error with webpack when WebSocket not exists #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building with webpack and you didn't define module.exports it will default to an empty object {}
So when transport.enabled test !!WebSocketDriver it returns true instead of false.
|
This feels like a bug in webpack. Have you found a related issue? |
|
I'm going to merge this change because it is straightforward. I do think this is a Webpack bug, but I see no harm here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with webpack and you didn't define module.exports it will default to an empty object {}
So when transport.enabled test !!WebSocketDriver it returns true instead of false.