[ts-sdk] Make react sdk run on browser #776
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noituri
force-pushed
the
@noituri/wasm-react-instance
branch
9 times, most recently
from
d0b04a1
to
02c0d0a
Compare
noituri
force-pushed
the
@noituri/wasm-react-instance
branch
from
02c0d0a
to
a08beaa
Compare
wkozyra95
reviewed
Sep 27, 2024
| @@ -2,7 +2,8 @@ import * as Api from '../api'; | |||
|
|
|||
| export type RegisterInput = | |||
| | ({ type: 'rtp_stream' } & RegisterRtpInput) | |||
| | ({ type: 'mp4' } & RegisterMp4Input); | |||
| | ({ type: 'mp4' } & RegisterMp4Input) | |||
| | { type: 'bytes' }; | |||
There was a problem hiding this comment.
bytes is not a valid type, I assume this will be raw frames? in that case frames or raw_frames, frame_bytes
What about audio? Is this video only input?
There was a problem hiding this comment.
Currently, it's only video input
noituri
force-pushed
the
@noituri/wasm-react-instance
branch
2 times, most recently
from
295d574
to
f6471eb
Compare
noituri
force-pushed
the
@noituri/wasm-react-instance
branch
from
f6471eb
to
f136ee8
Compare
noituri
force-pushed
the
@noituri/wasm-react-instance
branch
from
f136ee8
to
84100bb
Compare
noituri
force-pushed
the
@noituri/wasm-react-instance
branch
from
84100bb
to
bc13cb0
Compare
wkozyra95
reviewed
Oct 7, 2024
| const inputs = useInputStreams(); | ||
| const inputState = inputs['bunny_video']?.videoState; | ||
|
|
||
| if (!inputState || inputState == 'ready') { |
There was a problem hiding this comment.
Suggested change
| if (!inputState || inputState == 'ready') { | |
| if (inputState !== 'playing') { |
| } | ||
|
|
||
| public async registerInput(inputId: string, request: RegisterInput): Promise<void> { | ||
| await this.coreCompositor!.registerInput(inputId, intoRegisterInput(request)); |
There was a problem hiding this comment.
registerInput needs to handle internally initializing mp4(in the sendRequest implementation), otherwise hook with a new stream will trigger to early
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds bare minimum to make the wasm compositor work with our react sdk. It implements simple queue, mp4 input and canvas output. Not everything is fully implemented (i.e. Input state notifications) but I want to get the feedback early before proceeding further.