Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update community page in the documentation #3463

Merged
merged 3 commits into from
Aug 13, 2022

Conversation

j-piasecki
Copy link
Member

@j-piasecki j-piasecki commented Aug 11, 2022

Description

At the moment the images in the community page in the docs are a bit large. For some reason (I haven't investigated) the class applied to the img tag gets overwritten, so I added a div wrapping the images and applied the class to that element. Also updated the current team and hidden the arrow next to the GitHub logo in the navbar.

Changes

Wrapped the images with a div with the correct class applied.
Updated the current team.
Hidden the arrow next to the GitHub logo in the navbar.

Test code and steps to reproduce

Visit https://docs.swmansion.com/react-native-reanimated/docs/next/community/ and change version

Checklist

  • Included code example that can be used to test this change
  • Updated TS types
  • Added TS types tests
  • Added unit / integration tests
  • Updated documentation
  • Ensured that CI passes

@j-piasecki j-piasecki changed the title Fix images size in community page in the documentation Update community page in the documentation Aug 12, 2022
@piaskowyk piaskowyk merged commit 28abaa1 into main Aug 13, 2022
@piaskowyk piaskowyk deleted the @jpiasecki/fix-community-images-docs branch August 13, 2022 15:42
piaskowyk pushed a commit that referenced this pull request Aug 17, 2022
## Description

At the moment the images in the community page in the docs are a bit large. For some reason (I haven't investigated) the class applied to the `img` tag gets overwritten, so I added a `div` wrapping the images and applied the class to that element. Also updated the current team and hidden the arrow next to the GitHub logo in the navbar.

## Changes

Wrapped the images with a div with the correct class applied.
Updated the current team.
Hidden the arrow next to the GitHub logo in the navbar.

<!--
Please describe things you've changed here, make a **high level** overview, if change is simple you can omit this section.

For example:

- Added `foo` method which add bouncing animation
- Updated `about.md` docs
- Added caching in CI builds

-->

## Test code and steps to reproduce

Visit https://docs.swmansion.com/react-native-reanimated/docs/next/community/ and change version

<!--
Please include code that can be used to test this change and short description how this example should work.
This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example)
-->

## Checklist

- [ ] Included code example that can be used to test this change
- [ ] Updated TS types
- [ ] Added TS types tests
- [ ] Added unit / integration tests
- [ ] Updated documentation
- [ ] Ensured that CI passes
fluiddot pushed a commit to wordpress-mobile/react-native-reanimated that referenced this pull request Jun 5, 2023
## Description

At the moment the images in the community page in the docs are a bit large. For some reason (I haven't investigated) the class applied to the `img` tag gets overwritten, so I added a `div` wrapping the images and applied the class to that element. Also updated the current team and hidden the arrow next to the GitHub logo in the navbar.

## Changes

Wrapped the images with a div with the correct class applied.
Updated the current team.
Hidden the arrow next to the GitHub logo in the navbar.

<!--
Please describe things you've changed here, make a **high level** overview, if change is simple you can omit this section.

For example:

- Added `foo` method which add bouncing animation
- Updated `about.md` docs
- Added caching in CI builds

-->

## Test code and steps to reproduce

Visit https://docs.swmansion.com/react-native-reanimated/docs/next/community/ and change version

<!--
Please include code that can be used to test this change and short description how this example should work.
This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example)
-->

## Checklist

- [ ] Included code example that can be used to test this change
- [ ] Updated TS types
- [ ] Added TS types tests
- [ ] Added unit / integration tests
- [ ] Updated documentation
- [ ] Ensured that CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants