-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-navigation: App randomly freezes when react-native Modal is shown while preventing remove screen with usePreventRemove on iOS #2125
Comments
Hey @BadLice, thanks for reporting the issue. Would you mind to check whether haven't fixed the issue? As this PR landed already on main you can test it by installing this library from source code by putting following in your "react-native-screens": "software-mansion/react-native-screens#main" |
hi @kkafar, thank you for your response. unfortunately, this PR didn't fix my issue; i created a new branch in my reproducer app resolving this library from main branch, so you can see the issue still persists: https:/BadLice/modal-freeze-reproducer/tree/react-native-screens-main |
hi @hirbod, thanks for your response. Your PR fixed my issue! instead, passing Thank you! |
@kkafar I'll prepare a reproducer for you now, but as you can see, my PR solves even more issues :) |
Description
I have a NativeStackNavigator with 2 screens; on the first screen i have a button to navigate to the second screen; on the second screen, i am using the
usePreventRemove
hook to show a confirmation modal to the user when i tries to navigate to the previous screen;here it is an example of the bug behaviour:
RPReplay_Final1715264311.MOV
Steps to reproduce
the freeze occurs randomly, so repeating steps from 3 to 5 multiple times is sometimes needed. in order to enhance the chances of the bug to occur, it is useful to run the app on a physical device (iPhone) and repeat steps from 3 to 5 multiple times rapidly. I was able to reproduce the bug only on iOS
Snack or a link to a repository
https:/BadLice/modal-freeze-reproducer
Screens version
3.31.1
React Native version
0.74.1
Platforms
iOS
JavaScript runtime
Hermes
Workflow
React Native (without Expo)
Architecture
Paper (Old Architecture)
Build type
Debug mode
Device
Real device
Device model
iPhone 12
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: