Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: web exports on prepare file #2430

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: web exports on prepare file #2430

wants to merge 4 commits into from

Conversation

migueldaipre
Copy link

@migueldaipre migueldaipre commented Aug 28, 2024 •
edited
Loading

Summary

Fixes #2401

Fixes error in prepare.ts file that imports hasTouchableProperty from a '.' file.

It's probably related to the way ESM works, I'm not sure. I base it on PR

(0 , _.hasTouchableProperty) is not a function 
TypeError: (0 , _.hasTouchableProperty) is not a function 
at prepare
image

Test Plan

Should work without error on web

web-working.mov

Compatibility

OS Implemented
Web ✅

Checklist

  • I have tested this on a web project

@migueldaipre migueldaipre changed the title Fix web exports on prepare file fix: web exports on prepare file Aug 28, 2024
@a-eid
Copy link

a-eid commented Oct 18, 2024

this worked for me. patched the package for now. thanks @migueldaipre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@migueldaipre @a-eid