Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-34] Remove audioDevice from iOS WhipClient constructor #12

Conversation

gredajustyna
Copy link
Collaborator

@gredajustyna gredajustyna commented Aug 21, 2024

As it was not used, the audioDevice configuration has been removed from iOS.

Copy link

linear bot commented Aug 21, 2024

MOB-34 Remove audioDevice from iOS WhipClient constructor

Currently it is declared but not used. Instead it should be checked if user wants to stream audio at all and a boolean optional variable should be passed to indicate this

@gredajustyna gredajustyna changed the title [MOB-34remove audiodevice from ios whipclient constructor [MOB-34] Remove audioDevice from iOS WhipClient constructor Aug 21, 2024
Copy link
Member

@graszka22 graszka22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I wonder if we can use it later to for example use a microphone from bluetooth speakers instead of built in microphone.

@gredajustyna gredajustyna merged commit 95efdd8 into main Aug 23, 2024
1 check passed
@gredajustyna gredajustyna deleted the justynagreda/mob-34-remove-audiodevice-from-ios-whipclient-constructor branch August 23, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants