Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add iconUrl to ValidatorInfo type #2919

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

ronnyhaase
Copy link
Contributor

Adds iconUrl to validator Info type in /library-legacy/src/validator-info.ts.

As can be seen when running solana -um validator-info get, validators have already started adding it to their information.

I couldn't find code regarding this in the TP, but I'm happy to add it if I missed it.

Copy link

changeset-bot bot commented Jul 6, 2024

⚠️ No Changeset found

Latest commit: 0047eb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot added the community label Jul 6, 2024
@mergify mergify bot requested a review from a team July 6, 2024 17:48
@@ -33,6 +33,8 @@ export type Info = {
website?: string;
/** optional, extra information the validator chose to share */
details?: string;
/** optional, validator logo URL
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a closing */ here.

@steveluscher steveluscher changed the title Add iconUrl to validator Info type feat: add iconUrl to ValidatorInfo type Jul 8, 2024
@steveluscher steveluscher merged commit 3c67d8a into solana-labs:master Jul 8, 2024
5 checks passed
Copy link
Contributor

github-actions bot commented Jul 8, 2024

🎉 This PR is included in version 1.95.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants