Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use serde provided serialization for atomics #10096

Merged
merged 2 commits into from
May 18, 2020

Conversation

svenski123
Copy link
Contributor

Use serde provided functions for serializing / deserializing atomics instead of the functions in serde_utils which are functionally equivalent.

Remove unused functions in serde_utils.

Note serde_utils.rs is left as an empty file for other PRs that will add to it.

@ryoqun
Copy link
Member

ryoqun commented May 18, 2020

horray for working on this quickly!

@svenski123 it seems that our ci doesn't like empty files...

I think this file can just completely go away and put snapshot versioned code in serde_snapshot.rs or similar to make the file name more appropriate in #9980.

@ryoqun
Copy link
Member

ryoqun commented May 18, 2020

Ah, also if you're bothered with rebasing in general. Please feel free to to any git rebase --squash on #9980. :)

@ryoqun ryoqun self-requested a review May 18, 2020 14:17
@ryoqun ryoqun added the automerge Merge this Pull Request automatically once CI passes label May 18, 2020
Copy link
Member

@ryoqun ryoqun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really thank you!

@solana-grimes solana-grimes merged commit 4ca352a into solana-labs:master May 18, 2020
@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #10096 into master will increase coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10096   +/-   ##
=======================================
  Coverage    81.5%    81.5%           
=======================================
  Files         283      282    -1     
  Lines       65930    65904   -26     
=======================================
- Hits        53785    53765   -20     
+ Misses      12145    12139    -6     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants