Support for returnData in simulate transaction #26499
Conversation
| if (mockServer) { | ||
| it('returnData on simulateTransaction', async () => { | ||
| const tx = new Transaction(); | ||
| tx.feePayer = Keypair.generate().publicKey; |
There was a problem hiding this comment.
@joncinque It's worth noting that this will only work with a funded feePayer, which makes simulation somewhat problematic for second-order return-data apis. That doesn't need to hold up anything here, but just something to think about for usage and documentation purposes.
There was a problem hiding this comment.
Yeah true, I was thinking we could at least support it in its current state and improve on it later. Just to be totally clear, when you say "that doesn't need to hold up anything here", do you mean that you're ok with the approach?
Also, did we ever come up with a model for simulating transactions without a funded fee payer?
There was a problem hiding this comment.
Yep, I’m fine with this approach.
No, we haven’t designed implemented a way to bypass fee-payer check in simulation
Codecov Report
@@ Coverage Diff @@
## master #26499 +/- ##
===========================================
- Coverage 81.9% 77.4% -4.5%
===========================================
Files 631 40 -591
Lines 174252 2370 -171882
Branches 0 343 +343
===========================================
- Hits 142728 1836 -140892
+ Misses 31524 406 -31118
- Partials 0 128 +128 |
atharmohammad
force-pushed
the
returnData
branch
from
a283c34
to
b0af607
Compare
atharmohammad
force-pushed
the
returnData
branch
from
b0af607
to
156affc
Compare
| nullable( | ||
| pick({ | ||
| programId: string(), | ||
| data: tuple([string(), literal('base64')]), |
There was a problem hiding this comment.
need to hard code base64 here since TransactionReturnDataEncoding is a type and was giving error, don't know if there is any way to avoid this.
There was a problem hiding this comment.
We can eventually use some other type, but no problem with doing that here
|
Looks great, thanks for the contribution! |
feat(web3.js): add Support for returnData in simulate transaction
The PR adds --
1). support for
returnDatatoSimulatedTransactionResponsewith a unit test.2). return test data in
noop programto read the data back from thereturnDatafield in the response.3). live test with test-validator, simulating transaction on
noop programto read thereturnData.cc: @joncinque