Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add compute units to jsonrpc parser #27554

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Sep 1, 2022

Problem

computeUnitsConsumed is returned in RPC transaction metadata responses but it's not included in the exported type

Summary of Changes

Re-applies the changes from the reverted #27466 change

Fixes #

@jstarry jstarry added the automerge Merge this Pull Request automatically once CI passes label Sep 1, 2022
Copy link
Contributor

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #27554 (cb57f8f) into master (31087b8) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #27554     +/-   ##
=========================================
- Coverage    76.7%    76.6%   -0.1%     
=========================================
  Files          52       52             
  Lines        2657     2657             
  Branches      365      365             
=========================================
- Hits         2039     2037      -2     
- Misses        485      486      +1     
- Partials      133      134      +1     

@mergify mergify bot merged commit da7e88f into solana-labs:master Sep 1, 2022
@jstarry jstarry deleted the web3/compute-units-consumed branch September 16, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants