Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove failing request units test #27735

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Sep 12, 2022

Problem

Now that the request units instruction is deprecated by the runtime, the test validator fails any transactions which use it.

Summary of Changes

  • Remove failing test
  • Mark ComputeBudget.requestUnits function as deprecated

Fixes #

@jstarry jstarry added the automerge Merge this Pull Request automatically once CI passes label Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #27735 (b78b97d) into master (e779032) will increase coverage by 0.4%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #27735     +/-   ##
=========================================
+ Coverage    76.9%    77.3%   +0.4%     
=========================================
  Files          48       55      +7     
  Lines        2505     2888    +383     
  Branches      355      402     +47     
=========================================
+ Hits         1927     2234    +307     
- Misses        448      513     +65     
- Partials      130      141     +11     

@mergify mergify bot merged commit 8bb0acc into solana-labs:master Sep 12, 2022
@jstarry jstarry deleted the web3/fix-deprecated-test branch September 12, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants