Fix hostname part of queries in dashboard #3161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgarg66
commented
Mar 6, 2019
| @@ -5156,7 +5156,7 @@ | |||
| "measurement": "counter-cluster_info-vote-count", | |||
| "orderByTime": "ASC", | |||
| "policy": "autogen", | |||
| "query": "SELECT mean(\"packets_received\") as \"packets_received\" FROM \"$testnet\".\"autogen\".\"net-stats\" WHERE host_id =~ /$hostid/ AND $timeFilter GROUP BY time(5s) fill(null)\n\n\n\n", | |||
| "query": "SELECT mean(\"packets_received\") as \"packets_received\" FROM \"$testnet\".\"autogen\".\"net-stats\" WHERE hostname =~ /$hostid/ AND $timeFilter GROUP BY time(5s) fill(null)\n\n\n\n", | |||
There was a problem hiding this comment.
I thought about changing hostname to host_id in the net-stats and other scripts. That seems better approach, but it'll make older data format not parsable by the dashboard.
mvines
approved these changes
Mar 6, 2019
buffalojoec
pushed a commit
to buffalojoec/solana
that referenced
this pull request
Oct 15, 2024
Co-authored-by: Justin Starry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The hostname part of some queries is looking up for the wrong keyword.
Summary of Changes
Change the keyword to match what's being stored in DB
Fixes #3156