Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable local cluster native processors #3676

Merged

Conversation

jackcmay
Copy link
Contributor

@jackcmay jackcmay commented Apr 8, 2019

Problem

When starting a LocalCluster there is no way to add native instruction processors

Summary of Changes

Modify the LocalCluster API to allow callers to specify additional native instruction processors

Fixes #

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #3676 into master will decrease coverage by <.1%.
The diff coverage is 80%.

@@           Coverage Diff            @@
##           master   #3676     +/-   ##
========================================
- Coverage    79.6%   79.6%   -0.1%     
========================================
  Files         155     155             
  Lines       24863   24867      +4     
========================================
+ Hits        19805   19808      +3     
- Misses       5058    5059      +1

@jackcmay jackcmay requested review from sakridge and mvines April 8, 2019 17:23
Copy link
Member

@sakridge sakridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackcmay
Copy link
Contributor Author

jackcmay commented Apr 8, 2019

Adding @mvines for post-merge review in case we want to rework this

@jackcmay jackcmay merged commit 44b3910 into solana-labs:master Apr 8, 2019
@jackcmay jackcmay deleted the local_cluster_add_native_processors branch April 8, 2019 18:19
@mvines
Copy link
Member

mvines commented Apr 8, 2019

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants