Split signature throughput tracking out of FeeCalculator
#8447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
commented
Feb 25, 2020
t-nelson
force-pushed
the
fee_calc_amputation
branch
from
74a7539
to
f303562
Compare
Codecov Report
@@ Coverage Diff @@
## master #8447 +/- ##
========================================
- Coverage 80.3% 80.1% -0.2%
========================================
Files 256 256
Lines 56554 55279 -1275
========================================
- Hits 45413 44297 -1116
+ Misses 11141 10982 -159 |
mvines
reviewed
Feb 26, 2020
mvines
reviewed
Feb 26, 2020
t-nelson
force-pushed
the
fee_calc_amputation
branch
3 times, most recently
from
f6fb667
to
4c5f81a
Compare
|
@mvines how are we looking here? |
mvines
reviewed
Feb 28, 2020
Leaving `FeeCalculator` to *only* calculate transaction fees
Appease BPF tests
This reverts commit f303562.
t-nelson
force-pushed
the
fee_calc_amputation
branch
from
4c5f81a
to
54c4254
Compare
mergify
bot
dismissed
CriesofCarrots’s stale review
Pull request has been modified.
|
@mvines last 4 should resolve the outstandings. While updating the docs I was reminded that we have a solana/sdk/src/fee_calculator.rs Lines 104 to 106 in fe63a19 |
mvines
reviewed
Feb 28, 2020
mvines
previously approved these changes
Feb 28, 2020
mergify bot
pushed a commit
that referenced
this pull request
Mar 4, 2020
* SDK: Split new `FeeRateGovernor` out of `FeeCalculator` Leaving `FeeCalculator` to *only* calculate transaction fees * Replace `FeeCalculator` with `FeeRateGovernor` as appropriate * Expose recent `FeeRateGovernor` to clients * Move `burn()` back into `FeeCalculator` Appease BPF tests * Revert "Move `burn()` back into `FeeCalculator`" This reverts commit f303562. * Adjust BPF `Fee` sysvar test to reflect removal of `burn()` from `FeeCalculator` * Make `FeeRateGovernor`'s `lamports_per_signature` private * rebase artifacts * fmt * Drop 'Recent' * Drop _with_commitment variant * Use a more portable integer for `target_signatures_per_slot` * Add docs for `getReeRateCalculator` JSON RPC method * Don't return `lamports_per_signature` in `getFeeRateGovernor` JSONRPC reply (cherry picked from commit 90bedd7)
solana-grimes
pushed a commit
that referenced
this pull request
Mar 4, 2020
danpaul000
pushed a commit
to danpaul000/solana
that referenced
this pull request
Jul 8, 2020
…bs#8447) * SDK: Split new `FeeRateGovernor` out of `FeeCalculator` Leaving `FeeCalculator` to *only* calculate transaction fees * Replace `FeeCalculator` with `FeeRateGovernor` as appropriate * Expose recent `FeeRateGovernor` to clients * Move `burn()` back into `FeeCalculator` Appease BPF tests * Revert "Move `burn()` back into `FeeCalculator`" This reverts commit f303562. * Adjust BPF `Fee` sysvar test to reflect removal of `burn()` from `FeeCalculator` * Make `FeeRateGovernor`'s `lamports_per_signature` private * rebase artifacts * fmt * Drop 'Recent' * Drop _with_commitment variant * Use a more portable integer for `target_signatures_per_slot` * Add docs for `getReeRateCalculator` JSON RPC method * Don't return `lamports_per_signature` in `getFeeRateGovernor` JSONRPC reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
FeeCalculatordoes too much. While initially intended as a utility to calculate transaction fees, it has grown to also track cluster signature throughput for calculating the next block'sFeeCalculator. This requires significantly more stored state, making it prohibitive to store aFeeCalculatoron chain as required to resolve #7967.Summary of Changes
Factor out signature throughput tracking to new
FeeRateGovernortypeReplace
FeeCalculatorwithFeeRateGovernoras appropriateExpose recent
FeeRateGovernorvia RPCToward #7967