Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump generic-array from 0.13.2 to 0.14.1 #9446

Merged
merged 3 commits into from
Apr 28, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Apr 11, 2020

Bumps generic-array from 0.13.2 to 0.14.1.

Changelog

Sourced from generic-array's changelog.

  • 0.14.1

    • Fix element conversions in arr! macro.
  • 0.14.0

    • Replace Into implementations with the more general From.
      • Requires minumum Rust version of 1.41.0
    • Fix unsoundness in arr! macro.
    • Fix meta variable misuse
    • Fix Undefined Behavior across the crate by switching to MaybeUninit
    • Improve some documentation and doctests
    • Add AsRef<[T; N]> and AsMut<[T; N]> impls to GenericArray<T, N>
    • Add Split impl for &GenericArray and &mut GenericArray
  • 0.13.2

    • Add feature more_lengths, which adds more From/Into implementations for arrays of various lengths.
  • 0.13.1

    • Mark GenericArray as #[repr(transparent)]
    • Implement Into<[T; N]> for GenericArray<T, N> up to N=32
  • 0.13.0

    • Allow arr! to be imported with use syntax.
      • Requires minumum Rust version of 1.30.1
  • 0.12.2

    • Implement FusedIterator for GenericArrayIter
  • 0.12.1

    • Use internal iteration where possible and provide more efficient internal iteration methods.
  • 0.12.0

    • Allow trailing commas in arr! macro.
    • BREAKING: Serialize GenericArray using serde tuples, instead of variable-length sequences. This may not be compatible with old serialized data.
  • 0.11.0

    • BREAKING Redesign GenericSequence with an emphasis on use in generic type parameters.
    • Add MappedGenericSequence and FunctionalSequence
      • Implements optimized map, zip and fold for GenericArray, &GenericArray and &mut GenericArray
    • BREAKING Remove map_ref, zip_ref and map_slice
      • map_slice is now equivalent to GenericArray::from_iter(slice.iter().map(...))
  • 0.10.0

    • Add GenericSequence, Lengthen, Shorten, Split and Concat traits.
    • Redefine transmute to avert errors.
  • 0.9.0

    • Rewrite construction methods to be well-defined in panic situations, correctly dropping elements.
    • NoDrop crate replaced by ManuallyDrop as it became stable in Rust core.
    • Add optimized map/map_ref and zip/zip_ref methods to GenericArray
  • 0.8.0

    • Implement AsRef, AsMut, Borrow, BorrowMut, Hash for GenericArray
    • Update serde to 1.0
... (truncated)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@ryoqun
Copy link
Member

ryoqun commented Apr 21, 2020

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/cargo/generic-array-0.14.1 branch from a98ddff to 2f955e9 Compare April 21, 2020 04:01
@ryoqun
Copy link
Member

ryoqun commented Apr 21, 2020

Interesting actually this generic_array update caused the stable-perf to fail to pass: https://buildkite.com/solana-labs/solana/builds/23063#d6a0796b-65d0-4677-81af-b5d49487f309/5622-5687

@ryoqun
Copy link
Member

ryoqun commented Apr 28, 2020

@mvines @jackcmay quick look at this finally: we need firstly to update our rust-bpf (currently, v1.39.0) to use rust 1.41.0 or later. And that's out my hand?:

Maybe, considering a patch release to the 1.41 release branch, we must better off to go for 1.41.1 or 1.4{2,3}.0.

generic-array's changelog:

0.14.0

  • Replace Into implementations with the more general From.
    • Requires minumum Rust version of 1.41.0 (emphasis mine)

@jackcmay
Copy link
Contributor

@ryoqun Looks like the only generic_array dependency that Rust BPF has is sdk/src/signature.rs and signature.rs is not required for programs. How about making generic_array an optional dependency of the SDK? I pushed a new commit, check it out

@ryoqun
Copy link
Member

ryoqun commented Apr 28, 2020

@ryoqun Looks like the only generic_array dependency that Rust BPF has is sdk/src/signature.rs and signature.rs is not required for programs. How about making generic_array an optional dependency of the SDK? I pushed a new commit, check it out

just nice. :)

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #9446 into master will decrease coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #9446     +/-   ##
========================================
- Coverage    80.5%   80.5%   -0.1%     
========================================
  Files         279     279             
  Lines       63658   63658             
========================================
- Hits        51285   51283      -2     
- Misses      12373   12375      +2     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants