Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flat Layout Sorting Fix #234

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Flat Layout Sorting Fix #234

wants to merge 2 commits into from

Conversation

siqpush
Copy link
Contributor

@siqpush siqpush commented Aug 6, 2023

#224

Issue
Sort is displayed with respect to tree structure

Cause
Flat Layouts (iflat, flat) are created downstream of their file tree build (sorting is done during the build).

Fix
Have the tree build reflect a flat layout by only appending nodes to the root if the user specifies a flat layout. Sorting (if applicable) for flat layouts had to be moved out of multi-threaded section to ensure comparisons are made against the result of all threads.

Test Fix
Flat tests to reflect new output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant