Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove branching in read_config_to_string #98

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Remove branching in read_config_to_string #98

merged 1 commit into from
Mar 29, 2023

Conversation

Masynchin
Copy link
Contributor

I have deleted this if-let branching, so that function becomes oneliner. I would use flat_map with closure, but it seems it is not welcomed here :)

I didn't test this changes, so I expect to be supervised by CI.

@solidiquis
Copy link
Owner

Thanks for the contribution @Masynchin :]

If you wouldn't mind taking care of the merge conflict I'd be happy to merge this in.

@Masynchin
Copy link
Contributor Author

Haven't resolve merge git conflicts for a while, but here we go. Did I do it right? Hope it is all right.

@solidiquis solidiquis merged commit a61a565 into solidiquis:master Mar 29, 2023
@solidiquis
Copy link
Owner

Yes you did :]

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants