-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handleAnchor and blob
links
#382
Comments
It seems like solid-router/src/data/events.ts Line 38 in 5ac8ff5
I wanted to send a pull request, but all the basePath stuff is mysterious enough. It costs nothing to add 1 line comment on a logic condition on the lines of "this check for X because Y and Z happens"
|
Honestly I don't know. Which is sort of the challenge with the router. Most the core logic was authored by the previous maintainer, and then was augmented by the community. I've been looking for people interested in helping maintaining the router because I haven't had the chance to look that deeply in how it works. |
Seems like
handleAnchor
errors when the link is ablob
, like in the solid playground https://playground.solidjs.com/anonymous/778914e0-e4ea-4292-90e4-236336d33e61The text was updated successfully, but these errors were encountered: