Update sonic_image_links_create_workflow.yml #885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xumia
reviewed
Oct 20, 2021
Comment on lines
+10
to
+11
| permissions: | ||
| actions: read|write |
There was a problem hiding this comment.
The permissions should be aligned with on and jobs, see https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#permissions
Need to change:
permissions:
actions: read|write
TO: (remove two space characters in front of each line)
permissions:
contents: read|write
(The permission is to write the repo contents, not manage actions itself)
There was a problem hiding this comment.
And the permissions are granted to GITHUB_TOKEN, I guess we need to use the token in the script to commit the change.
There was a problem hiding this comment.
You can test in your repo to use the GITHUB_TOKEN.
|
We shall explore this solution later. For now, this PR is not required. Hence closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated workflow file sonic_image_links_create_workflow.yml for permission as suggested.