Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use abort instead of exit in case calling SAI API failure (#2170)
- What I did Use abort instead of exit in case calling SAI API failure Currently, exit is used in functions handleSai{Create,Remove,Set,Get}Status on SAI failure while abort is used in some other functions on SAI failure. IMO using abort yields benefits: Consistent behavior in orchagent on SAI failure in mocked test, in case SAI failure occurs the test process will just exit silently, which makes it very difficult for developers to find out what happened. by using abort, a coredump will be generated, which helps developers nail down the issue. So we would like to use abort in all cases of receiving SAI failure. - Why I did it - How I verified it Manually test. Signed-off-by: Stephen Sun <[email protected]>
- Loading branch information