-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[202111][counterpoll | wartmark] | The tables related to QUEUE_WATERMARK counter are not generated on WATERMARK enable #11219
Labels
Comments
yxieca
added
Triaged
this issue has been triaged
Help Wanted 🆘
and removed
Triaged
this issue has been triaged
labels
Jun 22, 2022
Help from community is wanted. |
Also observed in 202205. |
IMO the correct logic should be:
|
5 tasks
liat-grozovik
pushed a commit
to sonic-net/sonic-swss
that referenced
this issue
Feb 23, 2023
This PR fixes the following issue: sonic-net/sonic-buildimage#11219 It's a cherry-pick (with conflicts resolution) for 202205 of the following PR: #2525 - What I did Align watermark flow with port configuration correct the queue, watermark and pg-drop counterpoll functionality according to cli commands - Why I did it the flow before this commit was wrong, when watermark counterpoll was enabled, stats wasn't created in FLEX_COUNTERS_DB and COUNTERS_DB unless enabling queue counterpoll as well. in the same way when pg-drop counterpoll was enabled stats weren't added until watermark was enabled. This is due to the wrong flow where queue and pg maps were generated only when queue or watermark (pg-watermark) key was detected in flexcountersorch.cpp - How I verified it manual testing VS test (updated to reflect current flow) - before this commit only queue was tested regression test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
The issue appears to be in current approach: the queue watermark counters are only generated when a specific key is passed to FlexCounter orch.
This means that enabling watermark group won't actually enable the relevant counters but only when a stats for queue is requested.
root@sonic:/home/admin# counterpoll watermark enable
https:/Azure/sonic-utilities/blob/202111/counterpoll/main.py#L223
https:/Azure/sonic-swss/blob/202111/orchagent/flexcounterorch.cpp#L118
Queue Watermark Counter map is generated only when user requests a stats for all queues:
root@sonic:/home/admin# counterpoll queue enable
https:/Azure/sonic-swss/blob/202111/orchagent/portsorch.cpp#L5394
Steps to reproduce the issue:
admin@sonic:~$ sudo counterpoll config-db disable
admin@sonic:~$ sudo reboot
The table related to QUEUE_WATERMARK is not generated. However, once we enable queue (
sudo counterpoll queue enable
), the tables related to QUEUE_WATERMARK can be created.Describe the results you received:
The tables related to QUEUE_WATERMARK counter are not generated on WATERMARK enable
Describe the results you expected:
The tables related to QUEUE_WATERMARK counter should be generated on WATERMARK enable
Output of
show version
:Output of
show techsupport
:Additional information you deem important (e.g. issue happens only occasionally):
The text was updated successfully, but these errors were encountered: