[tun_pkt]: Wait for AsyncSniffer to init fully #10346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Lee [email protected]
Why I did it
Tunnel packet handler can crash at system startup:
This is due to a race condition between netlink messages being sent by the kernel and the
AsyncSniffer
object inititalizing fully. It is possible for a netlink message to arrive and trigger a sniffer restart prior to the sniffer initializing itsself.stop_cb
variable, since the variable creation happens during the sniffer startup rather than during the creation of the sniffer object. If this occurs, the tunnel_packet_handler attempts to stop the sniffer, but this operation fails becauseself.stop_cb
doesn't exist yet.How I did it
After creating the sniffer object, block until the
self.stop_cb
attribute has been created.How to verify it
Run
sudo systemctl restart swss
and verify the tunnel packet handler does not crashWhich release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)