Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNMP will now bind on 0.0.0.0 if mgmt ip not specified in minigraph #253

Merged
merged 1 commit into from
Feb 4, 2017

Conversation

taoyl-ms
Copy link
Contributor

@taoyl-ms taoyl-ms commented Feb 3, 2017

Fix an issue that snmp will fail to start if mgmt ip is not specified in minigraph (e.g. default graph in oneimage where mgmt ip is from DHCP)

@taoyl-ms taoyl-ms requested a review from lguohan February 3, 2017 23:55
@@ -14,6 +13,7 @@
# AGENT BEHAVIOUR
#

{% if minigraph_mgmt_interface.addr | ipv4 %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is should only affect line 19, not other addresses.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't bind on any other addresses with port 161 anymore after you bind on 0.0.0.0:161


In reply to: 99453733 [](ancestors = 99453733)

@taoyl-ms taoyl-ms merged commit b2e4483 into sonic-net:master Feb 4, 2017
@taoyl-ms taoyl-ms deleted the taol/snmp_cfg_j2 branch February 23, 2017 04:04
kevinwangsk added a commit to kevinwangsk/sonic-buildimage that referenced this pull request Jan 8, 2019
…ange_event()

* Use default timeout value which will block the select function
* Submodule update for argument type issue in Select class

Submodule update sonic-swss-common:

e8caaea - Align the argument type with epoll_wait() (sonic-net#255)
3ea133d - [selectable]: Update throw message (sonic-net#253)

Signed-off-by: Kevin Wang <[email protected]>
lguohan pushed a commit that referenced this pull request Jan 8, 2019
…ange_event() (#2422)

* Use default timeout value which will block the select function
* Submodule update for argument type issue in Select class

Submodule update sonic-swss-common:

e8caaea - Align the argument type with epoll_wait() (#255)
3ea133d - [selectable]: Update throw message (#253)

Signed-off-by: Kevin Wang <[email protected]>
Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
- Instead of creating the switch and later setting the source MAC address,
  use the source MAC address as an attribute to create the switch.

- Move corresponding switch attribute code to above the switch creation.
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020
vivekrnv added a commit to vivekrnv/sonic-buildimage that referenced this pull request Apr 13, 2022
004b9a4 [202111] Handle error seen on system where vlan interface map is not present (sonic-net#252)
899cfdd [ci] add pr trigger for 202111 branch (sonic-net#253)

Signed-off-by: Vivek Reddy Karri <[email protected]>
judyjoseph pushed a commit that referenced this pull request Apr 15, 2022
004b9a4 [202111] Handle error seen on system where vlan interface map is not present (#252)
899cfdd [ci] add pr trigger for 202111 branch (#253)
sg893052 pushed a commit to sg893052/sonic-buildimage that referenced this pull request Apr 25, 2022
4.0: gNMI Subscription onchange test plan
vdahiya12 added a commit to vdahiya12/sonic-buildimage that referenced this pull request May 31, 2022
vdahiya@vdahiya-dev3:~/sonic-buildimage8/sonic-buildimage/src/sonic-platform-daemons$
git log --oneline 9ac12bf..master
0d90023 (HEAD -> master, origin/master, origin/HEAD, origin/202205) grpc
client implementation for active-active dualtor (sonic-net#248)
6b8bf69 [ycabled] Fix some syntax warnings in ycabled (sonic-net#263)
2bcf936 [ycabled] fix the posting for mux_cable_static_info per downlink
when ycabled is spawned; synchronizing executing Telemetry API (sonic-net#257)
ce217c0 Include changes from xcvr_api in transceiver_info table (sonic-net#253)
e0f8a35 Fix checkReplyType failed issue via recreating xcvr_table_helper
on forking subprocess (sonic-net#255)

f575a40 (origin/master, origin/HEAD, origin/202205, master)
[Credo][Ycable] changes for synchronizing executing Telemetry API's when
mux toggle is inprogress (sonic-net#280)
b043372 [sonic_ssd] Nokia-7215: "show platform ssdhealth" not showing
health percent (sonic-net#279)
d62d3d6 [CMIS]Fix low-power to high power mode transition (sonic-net#268)
f918125 [syseeprom] Enable display of vendor extension TLV content
(sonic-net#270)
4e08440 [Credo][Ycable] improve logging for Server Powered off/Faulty
cables (sonic-net#272)

Signed-off-by: vaibhav-dahiya <[email protected]>
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Jun 2, 2022
linkmgrd:
* 3c2b546 2022-05-31 | Add default route support to `active-active` state machine (sonic-net#78) (github/202205, master, 202205) [Jing Zhang]
* 6fa892e 2022-05-27 | Degrade `LinkProberStateMachineBase` virtual function logging level (sonic-net#80) [Longxiang Lyu]
* 7b695ca 2022-05-27 | Fix mux wait timer and peer mux wait timer (sonic-net#81) [Longxiang Lyu]

platform-daemons:
* 0d90023 2022-05-31 | grpc client implementation for active-active dualtor (sonic-net#248) (github/master, github/202205, master, 202205) [vdahiya12]
* 6b8bf69 2022-05-27 | [ycabled] Fix some syntax warnings in ycabled (sonic-net#263) [vdahiya12]
* 2bcf936 2022-05-24 | [ycabled] fix the posting for mux_cable_static_info per downlink when ycabled is spawned; synchronizing executing Telemetry API (sonic-net#257) [vdahiya12]
* ce217c0 2022-04-25 | Include changes from xcvr_api in transceiver_info table (sonic-net#253) [qinchuanares]
* e0f8a35 2022-04-22 | Fix checkReplyType failed issue via recreating xcvr_table_helper on forking subprocess (sonic-net#255) [Stephen Sun]

platform-common:
* f575a40 2022-05-24 | [Credo][Ycable] changes for synchronizing executing Telemetry API's when mux toggle is inprogress (sonic-net#280) (github/202205, master, 202205) [vdahiya12]
* b043372 2022-05-11 | [sonic_ssd] Nokia-7215: "show platform ssdhealth" not showing health percent (sonic-net#279) [bill-nokia]
* d62d3d6 2022-05-04 | [CMIS]Fix low-power to high power mode transition (sonic-net#268) [Prince George]
* f918125 2022-05-02 | [syseeprom] Enable display of vendor extension TLV content (sonic-net#270) [dflynn-Nokia]
* 4e08440 2022-04-14 | [Credo][Ycable] improve logging for Server Powered off/Faulty cables (sonic-net#272) [vdahiya12]

Signed-off-by: Ying Xie <[email protected]>
yxieca added a commit that referenced this pull request Jun 2, 2022
linkmgrd:
* 3c2b546 2022-05-31 | Add default route support to `active-active` state machine (#78) (github/202205, master, 202205) [Jing Zhang]
* 6fa892e 2022-05-27 | Degrade `LinkProberStateMachineBase` virtual function logging level (#80) [Longxiang Lyu]
* 7b695ca 2022-05-27 | Fix mux wait timer and peer mux wait timer (#81) [Longxiang Lyu]

platform-daemons:
* 0d90023 2022-05-31 | grpc client implementation for active-active dualtor (#248) (github/master, github/202205, master, 202205) [vdahiya12]
* 6b8bf69 2022-05-27 | [ycabled] Fix some syntax warnings in ycabled (#263) [vdahiya12]
* 2bcf936 2022-05-24 | [ycabled] fix the posting for mux_cable_static_info per downlink when ycabled is spawned; synchronizing executing Telemetry API (#257) [vdahiya12]
* ce217c0 2022-04-25 | Include changes from xcvr_api in transceiver_info table (#253) [qinchuanares]
* e0f8a35 2022-04-22 | Fix checkReplyType failed issue via recreating xcvr_table_helper on forking subprocess (#255) [Stephen Sun]

platform-common:
* f575a40 2022-05-24 | [Credo][Ycable] changes for synchronizing executing Telemetry API's when mux toggle is inprogress (#280) (github/202205, master, 202205) [vdahiya12]
* b043372 2022-05-11 | [sonic_ssd] Nokia-7215: "show platform ssdhealth" not showing health percent (#279) [bill-nokia]
* d62d3d6 2022-05-04 | [CMIS]Fix low-power to high power mode transition (#268) [Prince George]
* f918125 2022-05-02 | [syseeprom] Enable display of vendor extension TLV content (#270) [dflynn-Nokia]
* 4e08440 2022-04-14 | [Credo][Ycable] improve logging for Server Powered off/Faulty cables (#272) [vdahiya12]

Signed-off-by: Ying Xie <[email protected]>
yxieca pushed a commit that referenced this pull request Jun 4, 2022
…ove python2 sonic-platform-common wheel (#10994)

* [sonic-platform-common][sonic-platform-daemons] submodule update

vdahiya@vdahiya-dev3:~/sonic-buildimage8/sonic-buildimage/src/sonic-platform-daemons$
git log --oneline 9ac12bf..master
0d90023 (HEAD -> master, origin/master, origin/HEAD, origin/202205) grpc
client implementation for active-active dualtor (#248)
6b8bf69 [ycabled] Fix some syntax warnings in ycabled (#263)
2bcf936 [ycabled] fix the posting for mux_cable_static_info per downlink
when ycabled is spawned; synchronizing executing Telemetry API (#257)
ce217c0 Include changes from xcvr_api in transceiver_info table (#253)
e0f8a35 Fix checkReplyType failed issue via recreating xcvr_table_helper
on forking subprocess (#255)

f575a40 (origin/master, origin/HEAD, origin/202205, master)
[Credo][Ycable] changes for synchronizing executing Telemetry API's when
mux toggle is inprogress (#280)
b043372 [sonic_ssd] Nokia-7215: "show platform ssdhealth" not showing
health percent (#279)
d62d3d6 [CMIS]Fix low-power to high power mode transition (#268)
f918125 [syseeprom] Enable display of vendor extension TLV content
(#270)
4e08440 [Credo][Ycable] improve logging for Server Powered off/Faulty
cables (#272)

Signed-off-by: vaibhav-dahiya <[email protected]>

* remove python2 wheel for sonic-platform-common

Signed-off-by: vaibhav-dahiya <[email protected]>

* remove python2 platform_common definitions

Signed-off-by: vaibhav-dahiya <[email protected]>
mihirpat1 pushed a commit to mihirpat1/sonic-buildimage that referenced this pull request Feb 21, 2023
* include changes from xcvr_api in transceiver_info table

* include new items in test_xcvrd.py

* resolving comments, add four items related to c-cmis, and support both non-cmis and cmis compliant modules

Co-authored-by: Chuan Qin (QINCHUAN) <[email protected]>
snider-nokia pushed a commit to snider-nokia/sonic-buildimage that referenced this pull request Apr 6, 2023
mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024
…ic-utilities

[submodule][202205] Update submodule sonic-utilities to the latest HEAD automatically
mssonicbld added a commit that referenced this pull request Jun 27, 2024
…lly (#19325)

#### Why I did it
src/sonic-gnmi
```
* a610784 - (HEAD -> master, origin/master, origin/HEAD) Improve timeout for GNMI dbus service (#265) (3 days ago) [ganglv]
* b1c90c9 - Add unit test for vlan interface (#264) (6 days ago) [ganglv]
* fbf0234 - Add unit test for syslog config (#263) (6 days ago) [ganglv]
* 047fc29 - Add unit test for portchannel interface (#262) (6 days ago) [ganglv]
* 52dd8e7 - Add unit test for pg headroom (#261) (6 days ago) [ganglv]
* 8a10d9f - Add unit test for pfcwd status (#260) (6 days ago) [ganglv]
* 65a43bc - Add unit test for pfcwd interval (#259) (6 days ago) [ganglv]
* 0bbb9ef - Add unit test for ntp (#258) (7 days ago) [ganglv]
* e5c43a4 - Add unit test for monitor config (#257) (7 days ago) [ganglv]
* 8a8881e - Add unit test for mmu dynamic threshold (#256) (7 days ago) [ganglv]
* 76857df - Add unit test for lo interface (#255) (7 days ago) [ganglv]
* c35c69d - Add unit test for k8s config (#254) (8 days ago) [ganglv]
* dd0bdcf - Add unit test for IPV6 (#253) (8 days ago) [ganglv]
* 9a1133f - Add unit test for incremental qos (#252) (8 days ago) [ganglv]
* 9bf7969 - Add unit test for eth interface (#251) (8 days ago) [ganglv]
* 2e1eb05 - Add unit test for ECN config (#250) (8 days ago) [ganglv]
* 56f17eb - Add unit test for dynamic ACL (#249) (8 days ago) [ganglv]
* 388eba8 - Add unit test for DHCP relay (#245) (10 days ago) [ganglv]
* fd2fdf6 - Add unit test for CACL (#243) (11 days ago) [ganglv]
```
#### How I did it
#### How to verify it
#### Description for the changelog
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
…lly (sonic-net#19325)

#### Why I did it
src/sonic-gnmi
```
* a610784 - (HEAD -> master, origin/master, origin/HEAD) Improve timeout for GNMI dbus service (sonic-net#265) (3 days ago) [ganglv]
* b1c90c9 - Add unit test for vlan interface (sonic-net#264) (6 days ago) [ganglv]
* fbf0234 - Add unit test for syslog config (sonic-net#263) (6 days ago) [ganglv]
* 047fc29 - Add unit test for portchannel interface (sonic-net#262) (6 days ago) [ganglv]
* 52dd8e7 - Add unit test for pg headroom (sonic-net#261) (6 days ago) [ganglv]
* 8a10d9f - Add unit test for pfcwd status (sonic-net#260) (6 days ago) [ganglv]
* 65a43bc - Add unit test for pfcwd interval (sonic-net#259) (6 days ago) [ganglv]
* 0bbb9ef - Add unit test for ntp (sonic-net#258) (7 days ago) [ganglv]
* e5c43a4 - Add unit test for monitor config (sonic-net#257) (7 days ago) [ganglv]
* 8a8881e - Add unit test for mmu dynamic threshold (sonic-net#256) (7 days ago) [ganglv]
* 76857df - Add unit test for lo interface (sonic-net#255) (7 days ago) [ganglv]
* c35c69d - Add unit test for k8s config (sonic-net#254) (8 days ago) [ganglv]
* dd0bdcf - Add unit test for IPV6 (sonic-net#253) (8 days ago) [ganglv]
* 9a1133f - Add unit test for incremental qos (sonic-net#252) (8 days ago) [ganglv]
* 9bf7969 - Add unit test for eth interface (sonic-net#251) (8 days ago) [ganglv]
* 2e1eb05 - Add unit test for ECN config (sonic-net#250) (8 days ago) [ganglv]
* 56f17eb - Add unit test for dynamic ACL (sonic-net#249) (8 days ago) [ganglv]
* 388eba8 - Add unit test for DHCP relay (sonic-net#245) (10 days ago) [ganglv]
* fd2fdf6 - Add unit test for CACL (sonic-net#243) (11 days ago) [ganglv]
```
#### How I did it
#### How to verify it
#### Description for the changelog
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Aug 1, 2024
…lly (sonic-net#19325)

#### Why I did it
src/sonic-gnmi
```
* a610784 - (HEAD -> master, origin/master, origin/HEAD) Improve timeout for GNMI dbus service (sonic-net#265) (3 days ago) [ganglv]
* b1c90c9 - Add unit test for vlan interface (sonic-net#264) (6 days ago) [ganglv]
* fbf0234 - Add unit test for syslog config (sonic-net#263) (6 days ago) [ganglv]
* 047fc29 - Add unit test for portchannel interface (sonic-net#262) (6 days ago) [ganglv]
* 52dd8e7 - Add unit test for pg headroom (sonic-net#261) (6 days ago) [ganglv]
* 8a10d9f - Add unit test for pfcwd status (sonic-net#260) (6 days ago) [ganglv]
* 65a43bc - Add unit test for pfcwd interval (sonic-net#259) (6 days ago) [ganglv]
* 0bbb9ef - Add unit test for ntp (sonic-net#258) (7 days ago) [ganglv]
* e5c43a4 - Add unit test for monitor config (sonic-net#257) (7 days ago) [ganglv]
* 8a8881e - Add unit test for mmu dynamic threshold (sonic-net#256) (7 days ago) [ganglv]
* 76857df - Add unit test for lo interface (sonic-net#255) (7 days ago) [ganglv]
* c35c69d - Add unit test for k8s config (sonic-net#254) (8 days ago) [ganglv]
* dd0bdcf - Add unit test for IPV6 (sonic-net#253) (8 days ago) [ganglv]
* 9a1133f - Add unit test for incremental qos (sonic-net#252) (8 days ago) [ganglv]
* 9bf7969 - Add unit test for eth interface (sonic-net#251) (8 days ago) [ganglv]
* 2e1eb05 - Add unit test for ECN config (sonic-net#250) (8 days ago) [ganglv]
* 56f17eb - Add unit test for dynamic ACL (sonic-net#249) (8 days ago) [ganglv]
* 388eba8 - Add unit test for DHCP relay (sonic-net#245) (10 days ago) [ganglv]
* fd2fdf6 - Add unit test for CACL (sonic-net#243) (11 days ago) [ganglv]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants