Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build]: Fix comparing docker versions #3205

Merged
merged 10 commits into from
Jul 23, 2019

Conversation

pavel-shirshov
Copy link
Contributor

- What I did
Fixed issue, which caused make fails with newer docker distributions

pavelsh@pavelsh-vm:~/disk2/sonic-buildimage$ make configure PLATFORM=broadcom
+++ Making configure +++
BLDENV=stretch make -f Makefile.work configure
make[1]: Entering directory '/disk2/sonic-buildimage'
Makefile.work:52: *** SONiC requires Docker version 17.06.1 or later.  Stop.
make[1]: Leaving directory '/disk2/sonic-buildimage'
Makefile:19: recipe for target 'configure' failed
make: *** [configure] Error 
pavelsh@pavelsh-vm:~$ docker version
Client: Docker Engine - Community
 Version:           19.03.0
 API version:       1.40
 Go version:        go1.12.5
 Git commit:        aeac949
 Built:             Wed Jul 17 18:16:07 2019
 OS/Arch:           linux/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          19.03.0
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.12.5
  Git commit:       aeac949
  Built:            Wed Jul 17 18:14:42 2019
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.2.6
  GitCommit:        894b81a4b802e4eb2a91d1ce216b8817763c29fb
 runc:
  Version:          1.0.0-rc8
  GitCommit:        425e105d5a03fabd737a126ad93d62a9eeede87f
 docker-init:
  Version:          0.18.0
  GitCommit:        fec3683

- How I did it
Docker version is extracted as 3rd value in "server version" string. But in my docker the 3d value is "version:" not 19.03.0. So I changed the code to return last value in the string.

- How to verify it
Try to use the build system with docker version 19.03

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lguohan lguohan changed the title Fix comparing docker versions [build]: Fix comparing docker versions Jul 23, 2019
@pavel-shirshov
Copy link
Contributor Author

Probably it's better to fix it using
docker version --format '{{.Server.Version}}
but I don't know sinic which version it is supported.

@lguohan lguohan merged commit 39b641e into sonic-net:master Jul 23, 2019
mssonicbld added a commit that referenced this pull request Jul 6, 2024
…lly (#19461)

#### Why I did it
src/sonic-swss
```
* 43ac585c - (HEAD -> master, origin/master, origin/HEAD) Revamp module build script to make it work for 5.15 on Ubuntu 20.04 (#3212) (3 days ago) [Saikrishna Arcot]
* c9c78dc4 - Fix in switchorch: unsupported attribute causes skipping of processing the rest of configurations (#3209) (3 days ago) [Amir]
* 0158d27d - [Chassis][voq] do not synchronize the system interface state if there is no rif assciated with the port (#3207) (3 days ago) [Arvindsrinivasan Lakshmi Narasimhan]
* fdd5bdc9 - [vxlanmgr]: Add disabling of fdb learning for linux vxlan interfaces (#3205) (3 days ago) [yfedoriachenko]
```
#### How I did it
#### How to verify it
#### Description for the changelog
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
…lly (sonic-net#19461)

#### Why I did it
src/sonic-swss
```
* 43ac585c - (HEAD -> master, origin/master, origin/HEAD) Revamp module build script to make it work for 5.15 on Ubuntu 20.04 (sonic-net#3212) (3 days ago) [Saikrishna Arcot]
* c9c78dc4 - Fix in switchorch: unsupported attribute causes skipping of processing the rest of configurations (sonic-net#3209) (3 days ago) [Amir]
* 0158d27d - [Chassis][voq] do not synchronize the system interface state if there is no rif assciated with the port (sonic-net#3207) (3 days ago) [Arvindsrinivasan Lakshmi Narasimhan]
* fdd5bdc9 - [vxlanmgr]: Add disabling of fdb learning for linux vxlan interfaces (sonic-net#3205) (3 days ago) [yfedoriachenko]
```
#### How I did it
#### How to verify it
#### Description for the changelog
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Aug 1, 2024
…lly (sonic-net#19461)

#### Why I did it
src/sonic-swss
```
* 43ac585c - (HEAD -> master, origin/master, origin/HEAD) Revamp module build script to make it work for 5.15 on Ubuntu 20.04 (sonic-net#3212) (3 days ago) [Saikrishna Arcot]
* c9c78dc4 - Fix in switchorch: unsupported attribute causes skipping of processing the rest of configurations (sonic-net#3209) (3 days ago) [Amir]
* 0158d27d - [Chassis][voq] do not synchronize the system interface state if there is no rif assciated with the port (sonic-net#3207) (3 days ago) [Arvindsrinivasan Lakshmi Narasimhan]
* fdd5bdc9 - [vxlanmgr]: Add disabling of fdb learning for linux vxlan interfaces (sonic-net#3205) (3 days ago) [yfedoriachenko]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants