Configure buffer profile to all ports #3561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendani
requested review from
pavel-shirshov,
stcheng,
renukamanavalan and
lguohan
|
This will make start of SONiC slower. So Fast-Reboot will stop working. |
|
Can we apply the settings on demand? We don't need the settings right-away. Let's apply them when we need them |
Signed-off-by: Wenda Ni <[email protected]>
wendani
force-pushed
the
buf_qos_all_ports_master
branch
from
c680836
to
eeb073f
Compare
wendani
changed the title
|
Drop qos. Apply only buffer profile to all ports. #3561 (comment) #3561 (comment) |
pavel-shirshov
approved these changes
Oct 4, 2019
renukamanavalan
approved these changes
Oct 4, 2019
|
retest vs please |
|
retest vsimage please |
renukamanavalan
pushed a commit
that referenced
this pull request
Oct 14, 2019
Signed-off-by: Wenda Ni <[email protected]>
renukamanavalan
pushed a commit
that referenced
this pull request
Oct 15, 2019
Signed-off-by: Wenda Ni <[email protected]>
wendani
added a commit
to wendani/sonic-buildimage
that referenced
this pull request
Oct 18, 2019
This reverts commit 8861cbe.
lguohan
pushed a commit
that referenced
this pull request
Oct 18, 2019
renukamanavalan
pushed a commit
that referenced
this pull request
Oct 18, 2019
yxieca
pushed a commit
that referenced
this pull request
Nov 8, 2019
Revert "Configure buffer profile to all ports (#3561)" (#3628) Configure buffer profile to all ports (#3561) This reverts commit 8861cbe. Signed-off-by: Wenda Ni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overwrites the current approach to configure only active ports, which have neighbors in the minigraph.
Signed-off-by: Wenda Ni [email protected]
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)