Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for SFF_8472/SFP+ standard #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lguohan
Copy link
Contributor

@lguohan lguohan commented Jun 25, 2017

No description provided.

@lguohan
Copy link
Contributor Author

lguohan commented Jun 26, 2017

DO NOT MERGE until test pass

Copy link
Contributor

@paulmenzel paulmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed, or can the merge/pull request be closed?

@@ -22,6 +22,7 @@ ORIG_FILE_URL = "https://sonicstorage.blob.core.windows.net/packages/linux_3.16.

$(addprefix $(DEST)/, $(MAIN_TARGET)): $(DEST)/% :
# Obtaining the Debian kernel source
set -e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated? Please split it out into a separate commit with an explanation.

@@ -1,116 +1,71 @@
Update SFF8436 EEPROM driver
Support newer kernel and remove eeprom_class dependency in sff_8436_eeprom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Has this been sent upstream? If yes, please add the references.
  2. Please format the patch file with git format-patch -1, so it can easily be applied with git am ….

@jarias-lfx
Copy link

/easycla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants