Added debug packages installation when SONIC_CONFIG_DEBUG enabled. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redis-tools package depends on libjemalloc1
This reverts commit 73b5fce. libjemalloc1 will be installed directly to orchagent and database
marian-pritsak
suggested changes
Feb 1, 2017
Dockerfile.j2
Outdated
| ## Install common debug-packages | ||
| {% if docker_base_dbgs %} | ||
| RUN apt-get -y install \ | ||
| {% for dbg_pkg in docker_base_dbgs.split(' ') -%} |
There was a problem hiding this comment.
No need to keep list of these packages in buildimage since they are not built bu it but installed directly from apt instead
Just put a list of packages here and use debug config directly in conditional
Dockerfile.j2
Outdated
| exim4-config \ | ||
| exim4-daemon-light | ||
|
|
||
| ## Install common debug-packages |
There was a problem hiding this comment.
Comment is relevant only when debug option is enabled
Move it inside conditional check
qiluo-msft
reviewed
Feb 6, 2017
Dockerfile.j2
Outdated
| {% if docker_base_dbgs %} | ||
| ## Install common debug-packages | ||
| RUN apt-get -y install \ | ||
| {% for dbg_pkg in docker_base_dbgs.split(' ') -%} |
There was a problem hiding this comment.
dbg_pkg [](start = 7, length = 7)
What is dbg_pkg for docker-base? #Closed
There was a problem hiding this comment.
See this pull request.
sonic-net/sonic-buildimage#234
qiluo-msft
reviewed
Feb 6, 2017
Dockerfile.j2
Outdated
|
|
||
| ## Clean up | ||
| RUN apt-get clean -y; apt-get autoclean -y; apt-get autoremove -y | ||
| ## Note: NO removing /var/lib/apt/lists/*, shared by all derived images |
There was a problem hiding this comment.
Why change this part? /var/lib/apt/lists/ will possibly be obsoleted and there is no benefit to be share then.
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
…onic-net#4) With adding more columns into the port_config.ini file, the previous logic of checking len(line.split()) == 4 is no longer valid. With adding the logic of parsing the title of the file, the port index could be directly retrieved depending on which column it is. Signed-off-by: Shu0T1an ChenG <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SONIC_CONFIG_DEBUG enabled, this script performs installation of the debug packages, listed in docker-base.mk