Add check ASIC vs DB state after comparison logic #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build fails? |
|
@kcudnik , can you take a look? |
|
yea, i send email about this, it's jenkins issue |
|
test this please |
|
Looks like your DB/SAI comparison is working! The only problem is that it surely triggers Broadcom SAI segment fault while comparing. Can you make it optional? I think the best way to trigger it might be reuse the syncd_request_shutdown program to send an event to check. What do you think? Alternative would be if you receive a signal then start checking. like USR1 :-) |
|
i would rather like to avoid using linux signals to make make something like this |
yxieca
approved these changes
Dec 5, 2018
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Dec 8, 2018
Includes changes: - Fix pre shutdown select (sonic-net/sonic-sairedis#397) - [.gitignore]: Add more files in .gitignore file (sonic-net/sonic-sairedis#396) - Add check ASIC vs DB state after comparison logic (sonic-net/sonic-sairedis#393) - Process only shutdown requests after pre shutdown (sonic-net/sonic-sairedis#395)
volodymyrsamotiy
pushed a commit
to volodymyrsamotiy/sonic-sairedis
that referenced
this pull request
Jul 30, 2019
* Add check ASIC vs DB state after comparison logic * Add aspell exceptions * Add cmd flag to enable consistency check explicitly
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
* Add check ASIC vs DB state after comparison logic * Add aspell exceptions * Add cmd flag to enable consistency check explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.